gh-103479: [Enum] require __new__ to be considered a data type #103495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or be a dataclass
ethanfurman
added
tests
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @ethanfurman, I could not cleanly backport this to |
|
GH-103514 is a backport of this pull request to the 3.11 branch. |
ethanfurman
added a commit
to ethanfurman/cpython
that referenced
this pull request
Apr 13, 2023
…ta type (pythonGH-103495) a mixin must either have a __new__ method, or be a dataclass, to be interpreted as a data-type. (cherry picked from commit a6f9594) Co-authored-by: Ethan Furman <[email protected]>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Apr 13, 2023
* main: pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495) pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494) pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502) pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500) pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507) pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228) pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463) pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
ethanfurman
added a commit
that referenced
this pull request
Apr 13, 2023
…GH-103495) (GH-103514) a mixin must either have a __new__ method, or be a dataclass, to be interpreted as a data-type; an __init__ method is not enough (restores pre-3.11 behavior for non-dataclasses). (cherry picked from commit a6f9594) Co-authored-by: Ethan Furman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or be a dataclass
Enumclass as of 3.11 #103479