Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100227: Make the Global PyModuleDef Cache Safe for Isolated Interpreters #103084

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable a prematurely-restrictive assert.
ericsnowcurrently committed Mar 28, 2023

Verified

This commit was signed with the committer’s verified signature.
Kubuxu Jakub Sztandera
commit ee70a96101040dac9fc07105a8022f40f557d317
2 changes: 1 addition & 1 deletion Python/import.c
Original file line number Diff line number Diff line change
@@ -1051,7 +1051,7 @@ _extensions_cache_clear_all(void)
{
/* The runtime (i.e. main interpreter) must be finalizing,
so we don't need to worry about the lock. */
assert(_Py_IsMainInterpreter(_PyInterpreterState_GET()));
// XXX assert(_Py_IsMainInterpreter(_PyInterpreterState_GET()));
Py_CLEAR(EXTENSIONS.dict);
_PyThreadState_ClearDetached(&EXTENSIONS.main_tstate);
}