Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101758: Add a Test For Single-Phase Init Module Variants #101891

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Feb 13, 2023

The new test exercises the most important variants for single-phase init extension modules. We also add some explanation about those variants to import.c.

@ericsnowcurrently ericsnowcurrently merged commit 096d009 into python:main Feb 14, 2023
@ericsnowcurrently ericsnowcurrently deleted the test-legacy-extension-with-state branch February 14, 2023 21:26
ericsnowcurrently added a commit that referenced this pull request Feb 17, 2023
…h-101969)

gh-101891 is causing failures under `$> ./python -m test test_imp -R 3:3`.  Furthermore, with that fixed, "test_singlephase_variants" is leaking references.  This change addresses the first part, but skips the leaking tests until we can follow up with a fix.

#101758
@gpshead
Copy link
Member

gpshead commented Feb 17, 2023

!buildbot Fedora Stable Refleaks

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b7bf588 🤖

The command will test the builders whose names match following regular expression: Fedora Stable Refleaks

The builders matched are:

@gpshead gpshead added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b7bf588 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants