Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98831: rewrite RAISE_VARARGS in the instruction definition DSL #101306

Merged
merged 7 commits into from
Jan 25, 2023
Merged

gh-98831: rewrite RAISE_VARARGS in the instruction definition DSL #101306

merged 7 commits into from
Jan 25, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 25, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 25, 2023
Closed
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 25, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 7fe1602 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 25, 2023
gvanrossum
gvanrossum reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Seems I forgot to send one comment.)

Python/bytecodes.c Outdated Show resolved Hide resolved
Python/generated_cases.c.h Outdated Show resolved Hide resolved
gvanrossum
gvanrossum reviewed Jan 25, 2023
View reviewed changes
Tools/cases_generator/test_generator.py Outdated
Comment on lines 346 to 347
PyObject *arg1 = PEEK(1);
PyObject *interim;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if you run the tests it'll fail here. I accidentally hit return in the middle of this line and didn't re-run these tests before pushing. As these tests aren't run automatically yet this didn't trigger any CI failures. :-(

I'll fix it in my next change to this file, but I figured I'd warn you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I also made a mess of my branch just now. Will fix in a bit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the makefile. Currently when I change the opcode_metadata.h file I need to touch compile.c. I had a look but wasn't sure what to change.

@iritkatriel iritkatriel merged commit b400219 into python:main Jan 25, 2023
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@iritkatriel @mdboom
pythongh-98831: rewrite RAISE_VARARGS in the instruction definition D…
16695a0 
…SL (python#101306)
@iritkatriel iritkatriel deleted the RAISE_VARARG branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @bedevere-bot @gvanrossum