-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-92123: Pass _elementtree state as parameter #101189
GH-92123: Pass _elementtree state as parameter #101189
Conversation
Passing the state around as a parameter is one way to get rid of |
(I will rebase this onto |
f0117f3
to
5fd0b8a
Compare
Pass state as arg to create_new_element()
Pass state as arg to deepcopy()
Pass state as arg to expat_set_error()
Pass state as arg to element_setstate_from_attributes()
Pass state as arg to create_elementiter()
Pass state as arg to treebuilder_extend_element_text_or_tail()
Pass state as arg to treebuilder_add_subelement()
Pass state as arg to element_add_subelement()
Pass state as arg to element_setstate_from_Python()
b853fba
to
fbd465a
Compare
fbd465a
to
0195c35
Compare
cc. @arhadthedev |
After this, the remaining parts are:
|
Up to you but I can review of all this in one go, they are relatively small changes. |
Side thought: |
Yes; well observed. |
Complement to #101190