Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pickling of ParamSpecArgs and ParamSpecKwargs is not covered #128615

Closed
sobolevn opened this issue Jan 8, 2025 · 0 comments
Closed

Pickling of ParamSpecArgs and ParamSpecKwargs is not covered #128615

sobolevn opened this issue Jan 8, 2025 · 0 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir topic-typing

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 8, 2025 •
edited by bedevere-app bot
Loading

Снимок экрана 2025-01-08 в 12 17 31

I also tried to remove these lines and executed (just to be sure):

./python.exe -m test test_typing test_types test_annotationlib test_type_annotations test_type_aliases test_type_params test_copyreg test_pickle

And all tests still pass.
So, I added a simple test for that.

Linked PRs
@sobolevn sobolevn added tests Tests in the Lib/test dir topic-typing labels Jan 8, 2025
@sobolevn sobolevn self-assigned this Jan 8, 2025
sobolevn added a commit to sobolevn/cpython that referenced this issue Jan 8, 2025
@sobolevn
pythongh-128615: Cover pickling of ParamSpecArgs and ParamSpecKwargs
0000302
@bedevere-app bedevere-app bot mentioned this issue Jan 8, 2025
Merged
sobolevn added a commit that referenced this issue Jan 8, 2025
@sobolevn
gh-128615: Cover pickling of ParamSpecArgs and ParamSpecKwargs (#…
74a5171 
…128616)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 8, 2025
@sobolevn @miss-islington
pythongh-128615: Cover pickling of ParamSpecArgs and `ParamSpecKwar…
e04b1f6 
…gs` (pythonGH-128616)

(cherry picked from commit 74a5171)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 8, 2025
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 8, 2025
@sobolevn @miss-islington
pythongh-128615: Cover pickling of ParamSpecArgs and `ParamSpecKwar…
313ac03 
…gs` (pythonGH-128616)

(cherry picked from commit 74a5171)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jan 8, 2025
Merged
AlexWaygood pushed a commit that referenced this issue Jan 8, 2025
@miss-islington @sobolevn
[3.12] gh-128615: Cover pickling of ParamSpecArgs and `ParamSpecKwa…
4c130c9 
…rgs` (GH-128616) (#128626)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this issue Jan 8, 2025
@miss-islington @sobolevn
[3.13] gh-128615: Cover pickling of ParamSpecArgs and `ParamSpecKwa…
7e099c5 
…rgs` (GH-128616) (#128625)

gh-128615: Cover pickling of `ParamSpecArgs` and `ParamSpecKwargs` (GH-128616)
(cherry picked from commit 74a5171)

Co-authored-by: sobolevn <[email protected]>
@sobolevn sobolevn closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir topic-typing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn