-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Check if generated files are up to date" job misses regen-unicodedata
and regen-limited-abi
#126524
Comments
I don't touch |
There's no need to add |
When I add
Does not seem like it is slow now. |
…H-126682) (cherry picked from commit ad9d059) Co-authored-by: sobolevn <[email protected]>
…H-126682) (cherry picked from commit ad9d059) Co-authored-by: sobolevn <[email protected]>
Feature or enhancement
Currently our
regen-all
is missing severalregen-
targets:While our CI job to check regenerated files does not check them:
cpython/.github/workflows/build.yml
Lines 120 to 124 in 2a6b6b3
This does not seem right, I think that we should add:
make regen-unicodedata
(it requires internet access, but GitHub jobs always have access, see gh-96954: Don't run regen-unicodedata in regen-all #112120)make regen-limited-abi
(needs to compile python to get the ABI)How long does it work? Testing locally first:
I propose adding these two
make
targets to the test to be extra safe.What do others think? :)
If agreed, I will send a PR.
Linked PRs
regen-unicodedata
as a part of our CI #126682regen-unicodedata
as a part of our CI (GH-126682) #127594regen-unicodedata
as a part of our CI (GH-126682) #127595The text was updated successfully, but these errors were encountered: