Dictionary watchers deliver added event before it's guaranteed to be successful leading to possible incosistent state
#122208
Labels
type-bug
An unexpected behavior, bug, or error
Comments
DinoV
added a commit
that referenced
this issue
Jul 24, 2024
…2207) Don't delivery PyDict_EVENT_ADDED until it can't fail
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this issue
Jul 24, 2024
Summary: Back port of: python/cpython#122207 fixing python/cpython#122208 The current dictionary watchers implementation delivers the added event before it checks to see if we need to re-size the dictionary. This resize can fail so the value isn't added, and then the tracker is out of sync with the true state of the dictionary. This moves the delivery of the event to after any necessary allocations have happened. Reviewed By: jbower-fb Differential Revision: D60182094 fbshipit-source-id: f34940e98ce1caadeee364f9d126d35839661961
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this issue
Jul 24, 2024
Summary: Back port of: python/cpython#122207 fixing python/cpython#122208 The current dictionary watchers implementation delivers the added event before it checks to see if we need to re-size the dictionary. This resize can fail so the value isn't added, and then the tracker is out of sync with the true state of the dictionary. This moves the delivery of the event to after any necessary allocations have happened. Reviewed By: jbower-fb Differential Revision: D60182094 fbshipit-source-id: f34940e98ce1caadeee364f9d126d35839661961
nohlson
pushed a commit
to nohlson/cpython
that referenced
this issue
Jul 24, 2024
python#122207) Don't delivery PyDict_EVENT_ADDED until it can't fail
nohlson
pushed a commit
to nohlson/cpython
that referenced
this issue
Jul 24, 2024
python#122207) Don't delivery PyDict_EVENT_ADDED until it can't fail
DinoV
added a commit
that referenced
this issue
Jul 30, 2024
…il (#122326) Don't delivery PyDict_EVENT_ADDED until it can't fail
DinoV
added a commit
that referenced
this issue
Jul 30, 2024
…il (#122327) Don't delivery PyDict_EVENT_ADDED until it can't fail
|
Triage: closing as the linked PRs are merged, please re-open if still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Bug description:
Currently dictionary watchers deliver the
PyDict_EVENT_ADDEDevent before they have done everything that is necessary to ensure success. If the dictionary requires a resize for insertion to succeed (or a new keys object needs to be allocated from an empty dict) and that fails then the dictionary watcher will have inconsistent state to what's stored in the dictionary. Watchers should only receive the event when the dictionary implementation is guaranteed that it will succeed.The event can still be delivered before the insertion happens meaning there's no visible change in behavior except for the OOM case.
CPython versions tested on:
3.12, CPython main branch
Operating systems tested on:
Linux
Linked PRs
The text was updated successfully, but these errors were encountered: