Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have make clobber delete builddir #106704

Closed
brettcannon opened this issue Jul 13, 2023 · 1 comment
Closed

Have make clobber delete builddir #106704

brettcannon opened this issue Jul 13, 2023 · 1 comment
Labels
build The build process and cross-build OS-wasi type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

When you run make distclean, it doesn't touch builddir, even though that's (currently) where cross-builds put their builds. The command should probably rm -r builddir (assuming we stick with builddir as the directory name; need to check with other core devs before this gets wider than Tools/wasm and .gitignore).
@brettcannon brettcannon added type-feature A feature request or enhancement build The build process and cross-build OS-wasi labels Jul 13, 2023
@brettcannon brettcannon changed the title Have make distclean delete builddir Have make clobber delete builddir Nov 22, 2023
@brettcannon brettcannon moved this from Todo to In Progress in WASI to tier 2 Nov 27, 2023
@brettcannon
Copy link
Member Author

Part of #112473 .

brettcannon added a commit that referenced this issue Nov 30, 2023
@brettcannon
GH-103065, GH-106704, GH-105253: Provide a Tools/wasm/wasi.py scrip…
37589d7 
…t to simplify doing a WASI build (GH-112473)
@github-project-automation github-project-automation bot moved this from In Progress to Done in WASI to tier 2 Nov 30, 2023
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@brettcannon @aisk
pythonGH-103065, pythonGH-106704, pythonGH-105253: Provide a `Tools/w…
82233bb 
…asm/wasi.py` script to simplify doing a WASI build (pythonGH-112473)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@brettcannon @Glyphack
pythonGH-103065, pythonGH-106704, pythonGH-105253: Provide a `Tools/w…
41a161a 
…asm/wasi.py` script to simplify doing a WASI build (pythonGH-112473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build OS-wasi type-feature A feature request or enhancement
Projects
No open projects
WASI to tier 2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettcannon