Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_traceback does not run one set of CPythonTracebackErrorCaretTests #106185

Closed
sobolevn opened this issue Jun 28, 2023 · 1 comment
Closed
Assignees
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 28, 2023

Based on @hugovk work in python/core-workflow#505 I found that we have two duplicated class CPythonTracebackErrorCaretTests here:

@cpython_only
@requires_debug_ranges()
class CPythonTracebackErrorCaretTests(
CAPIExceptionFormattingMixin,
TracebackErrorLocationCaretTestBase,
unittest.TestCase,
):
"""
Same set of tests as above but with Python's internal traceback printing.
"""
@cpython_only
@requires_debug_ranges()
class CPythonTracebackErrorCaretTests(
CAPIExceptionFormattingLegacyMixin,
TracebackErrorLocationCaretTestBase,
unittest.TestCase,
):
"""
Same set of tests as above but with Python's legacy internal traceback printing.
"""

So, first tests are not executed.
We need to rename on of them.

Before: Ran 236 tests in 2.453s
After: Ran 259 tests in 2.481s

Linked PRs

@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Jun 28, 2023
@sobolevn sobolevn self-assigned this Jun 28, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 28, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 25, 2023
…st_traceback` (pythonGH-106187)

(cherry picked from commit 7c89f11)

Co-authored-by: Nikita Sobolev <[email protected]>
serhiy-storchaka pushed a commit that referenced this issue Jul 25, 2023
…est_traceback` (GH-106187) (GH-107268)

(cherry picked from commit 7c89f11)

Co-authored-by: Nikita Sobolev <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this issue Jul 27, 2023
@hauntsaninja
Copy link
Contributor

Nice spot, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants