Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pathlib.WindowsPath.glob() preserves case of literal pattern segments #104114

Closed
barneygale opened this issue May 3, 2023 · 1 comment
Closed

pathlib.WindowsPath.glob() preserves case of literal pattern segments #104114

barneygale opened this issue May 3, 2023 · 1 comment
Labels
3.12 bugs and security fixes topic-pathlib type-bug An unexpected behavior, bug, or error

Comments

@barneygale
Copy link
Contributor

barneygale commented May 3, 2023 •
edited by bedevere-bot
Loading

When pathlib.WindowsPath.glob() evaluates a literal (non-wildcard) pattern segment, it returns paths using the case of the pattern segment, rather than the real filesystem case. This problem does not affect segments involving * or ** wildcards.

>>> from pathlib import WindowsPath
>>> next(WindowsPath().glob('LIB/PATHLIB.*'))
WindowsPath('LIB/pathlib.py')  # 'LIB' should be 'Lib'

Linked PRs
@barneygale barneygale added type-bug An unexpected behavior, bug, or error 3.12 bugs and security fixes topic-pathlib labels May 3, 2023
barneygale added a commit to barneygale/cpython that referenced this issue May 3, 2023
@barneygale
pythonGH-104114: Fix pathlib.WindowsPath.glob() use of literal patt…
1f58b94 
…ern segment case

We now use `_WildcardSelector` to evaluate literal pattern segments, which
allows us to retrieve the real filesystem case.

This change is necessary in order to implement a *case_sensitive* argument
(see pythonGH-81079) and a *follow_symlinks* argument (see pythonGH-77609).
@bedevere-bot bedevere-bot mentioned this issue May 3, 2023
Merged
barneygale added a commit to barneygale/cpython that referenced this issue May 3, 2023
@barneygale
Merge branch 'main' into pythongh-104114-windowspath-literal-pattern-…
6fd03f4 
…case
barneygale added a commit that referenced this issue May 3, 2023
@barneygale
GH-104114: Fix pathlib.WindowsPath.glob() use of literal pattern se…
da1980a 
…gment case (GH-104116)

We now use `_WildcardSelector` to evaluate literal pattern segments, which
allows us to retrieve the real filesystem case.

This change is necessary in order to implement a *case_sensitive* argument
(see GH-81079) and a *follow_symlinks* argument (see GH-77609).
@barneygale
Copy link
Contributor Author

Fixed in 3.12. Not backported as it relies on other changes in the 3.12 line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes topic-pathlib type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barneygale