Skip to content

Commit

Permalink
gh-104499: IDLE - fix completions for tk aqua 8.7 (#104591)
Browse files Browse the repository at this point in the history
  • Loading branch information
terryjreedy authored May 18, 2023
1 parent 7fc8e2d commit 678bf57
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 2 additions & 0 deletions Lib/idlelib/NEWS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Released on 2023-10-02
=========================


gh-104499: Fix completions for Tk Aqua 8.7 (currently blank).

gh-104486: Make About print both tcl and tk versions if different,
as is expected someday.

Expand Down
10 changes: 3 additions & 7 deletions Lib/idlelib/autocomplete_w.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,11 @@ def show_window(self, comp_lists, index, complete, mode, userWantsWin):
self.userwantswindow = userWantsWin
self.lasttypedstart = self.start

# Put widgets in place
self.autocompletewindow = acw = Toplevel(self.widget)
# Put it in a position so that it is not seen.
acw.wm_geometry("+10000+10000")
# Make it float
acw.withdraw()
acw.wm_overrideredirect(1)
try:
# This command is only needed and available on Tk >= 8.4.0 for OSX
# Without it, call tips intrude on the typing process by grabbing
# the focus.
# Prevent grabbing focus on maxOS.
acw.tk.call("::tk::unsupported::MacWindowStyle", "style", acw._w,
"help", "noActivates")
except TclError:
Expand Down Expand Up @@ -271,6 +266,7 @@ def winconfig_event(self, event):
# place acw above current line
new_y -= acw_height
acw.wm_geometry("+%d+%d" % (new_x, new_y))
acw.deiconify()
acw.update_idletasks()
except TclError:
pass
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix completions for Tk Aqua 8.7 (currently blank).

0 comments on commit 678bf57

Please sign in to comment.