Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the once method on Evented. #2023

Merged
merged 5 commits into from
Nov 17, 2024
Merged

Implement the once method on Evented. #2023

merged 5 commits into from
Nov 17, 2024

Conversation

hansthen
Copy link
Collaborator

@hansthen hansthen commented Nov 3, 2024

No description provided.

Conengmo
Conengmo approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have basically two comments, one about adding type hints, the other is more of a style thing. But nothing functional, so I'll approve it now already.

folium/elements.py Outdated Show resolved Hide resolved
folium/map.py Outdated Show resolved Hide resolved
folium/map.py Outdated Show resolved Hide resolved
folium/map.py Outdated Show resolved Hide resolved
hansthen and others added 4 commits November 17, 2024 14:50
@hansthen @Conengmo
Update folium/elements.py
d5c9f04 
Co-authored-by: Frank Anema <[email protected]>
@hansthen @Conengmo
Update folium/map.py
14a7711 
Co-authored-by: Frank Anema <[email protected]>
@hansthen @Conengmo
Update folium/map.py
a9374a7 
Co-authored-by: Frank Anema <[email protected]>
@hansthen @Conengmo
Update folium/map.py
342f0a5 
Co-authored-by: Frank Anema <[email protected]>
@hansthen
Copy link
Collaborator Author

Looks good! I have basically two comments, one about adding type hints, the other is more of a style thing. But nothing functional, so I'll approve it now already.

Okay thanks for those.

@hansthen hansthen merged commit 1f2d67b into python-visualization:main Nov 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conengmo Conengmo Conengmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hansthen @Conengmo