Add custom Template class with tojavascript filter #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansthen want to do a final review of this one? |
hansthen
approved these changes
Apr 3, 2024
Good idea! And thanks for the review! |
hansthen
pushed a commit
to hansthen/folium
that referenced
this pull request
Apr 3, 2024
Conengmo
added a commit
that referenced
this pull request
Apr 4, 2024
* Re: #1606 Add TreeLayerControl to Folium * add custom Template class with tojavascript filter (#1912) * Drop Bootstrap 3 and use separate glyphicons css file (#1914) --------- Co-authored-by: Frank Anema <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1856, split off from the more complete version in #1895.
Add a custom Template class that contains the
tojavascripttemplate filter that converts Python objects to Javascript notation. This may include Javascript object references or functions.Instead of applying this template everywhere at once, we'll adopt is gradually where it is useful. This is mainly when one of the arguments is a Javascript function or when we want to reference another Folium object in the Javascript template.