realtime plugin: allow str for JsCode arg #1862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea split off from #1856.
For defined keyword arguments that expect a Javascript function, allow not only the new
JsCode
class, but also str. AdaptJsCode
to allow bothstr
andJsCode
arguments for easier instantiation.This means that users can use these keyword arguments without having to deal with
JsCode
. AndJsCode
is only necessary for undefined keyword arguments that are Javascript functions.Upside of this is that users have less classes to worry about when using this plugin. Downside is it may be confusing that using a string doesn't work for undefined keyword arguments that are Javascript functions. But since that's a more advanced move, I hope those users can read and understand the docstring.