-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw export button refactor #1342
Closed
and-viceversa
wants to merge
11
commits into
python-visualization:main
from
and-viceversa:draw_export_refactor
Closed
Draw export button refactor #1342
and-viceversa
wants to merge
11
commits into
python-visualization:main
from
and-viceversa:draw_export_refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # folium/plugins/draw.py
stickler-ci
reviewed
May 26, 2020
Good that you're taking this on, that export button is weird.
About guidance on plugin development: folium has grown organically over the years with different maintainers, so that may explain the different styles in the code. |
This PR is quite stale, so I'll close it. If somebody wants to pick this up in a new PR and address the comment about putting the styling in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to the scope change in #1312.
draw.py
has an optional export button. As far as I can tell, there is no way to override its hardcoded<style>
. Moveexport_style
variable outside the Draw class and add Pythonic protected underscore. This shouldn't change default or expected behavior.Plugins seem more open to interpretation than the core library ... is there any guidance to avoid this sort of refactor in the first place? To me, this sort of property could also belong to
self
.