Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make _parse_size robust to already parsed values #142

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Make _parse_size robust to already parsed values #142

merged 4 commits into from
Oct 16, 2023

Conversation

BastienGauthier
Copy link
Contributor

@BastienGauthier BastienGauthier commented Oct 4, 2023 •
edited
Loading

This minor change is NOT needed if we want to be able to unpickle a folium Map afterwards, it is only there for code robustness.

@BastienGauthier BastienGauthier mentioned this pull request Oct 6, 2023
Closed
Conengmo
Conengmo requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have. If people want to put in sizes in the output format, why not let them.

Could you add some test cases to test_parse_size and test_parse_size_exceptions though?

@BastienGauthier
Copy link
Contributor Author

Good to go !

@Conengmo Conengmo merged commit ce17e54 into python-visualization:main Oct 16, 2023
10 checks passed
@Conengmo
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conengmo Conengmo Conengmo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BastienGauthier @Conengmo