Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #99 #100

Merged
merged 2 commits into from
Nov 3, 2012
Merged

Fixed #99 #100

merged 2 commits into from
Nov 3, 2012

Conversation

erfaan
Copy link
Contributor

@erfaan erfaan commented Nov 1, 2012

Introduced an optional parameter timeout which each API request.

@sixohsix
Copy link
Collaborator

sixohsix commented Nov 3, 2012

Hi,

the feature looks good, but special parameters to twitter calls are usually marked by leading underscores. e.g. _id and _method so that they do not block any parameter names Twitter decides to use. I would prefer this parameter be called _timeout. If you make that change I will definitely accept this pull request.

Thanks,

Mike.

…k any parameter names Twitter decides to use
@erfaan
Copy link
Contributor Author

erfaan commented Nov 3, 2012

Hi Mike,
I completely agree with your argument. Please check the updated code.

Thanks,
Irfan

@sixohsix
Copy link
Collaborator

sixohsix commented Nov 3, 2012

Quick coding! Thanks very much for your work.

sixohsix added a commit that referenced this pull request Nov 3, 2012
Fixed #99
Introduced an optional parameter `timeout` which each API request.
@sixohsix sixohsix merged commit 6ef18ed into python-twitter-tools:master Nov 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants