Rationalize generic exception names #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename BrokenStreamError to BrokenResourceError - Rename ResourceBusyError to BusyResourceError Fixes python-triogh-620 (and see there for the rationale).
njsmith
force-pushed
the
rationalize-generic-exceptions
branch
from
bc9efba to
016a508
Compare
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 83.97% 83.97% +<.01%
==========================================
Files 94 94
Lines 13006 13001 -5
Branches 783 783
==========================================
- Hits 10922 10918 -4
+ Misses 2062 2061 -1
Partials 22 22
Continue to review full report at Codecov.
|
|
Need to rerun that travis test after #702 is merged, but otherwise I think this is good to go. |
|
Do we need a news entry? |
|
Whoops, nice catch! I wrote one, but forgot to |
Yeah, it definitely saved me there :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-620 (and see there for the rationale).