Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement happy eyeballs #145

Merged
merged 5 commits into from
Aug 3, 2017
Merged

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented May 1, 2017

Not tested, not integrated, just want to get it off my laptop.

@njsmith njsmith changed the title First draft of some happy eyeballs code [WIP] First draft of some happy eyeballs code May 1, 2017
@codecov-io
Copy link

codecov-io commented May 1, 2017

Codecov Report

Merging #145 into master will increase coverage by 0.01%.
The diff coverage is 99.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   99.14%   99.15%   +0.01%     
==========================================
  Files          63       67       +4     
  Lines        8849     9189     +340     
  Branches      633      656      +23     
==========================================
+ Hits         8773     9111     +338     
- Misses         61       62       +1     
- Partials       15       16       +1
Impacted Files Coverage Δ
trio/ssl.py 100% <ø> (ø) ⬆️
trio/tests/test_ssl_helpers.py 100% <100%> (ø)
trio/_ssl_stream_helpers.py 100% <100%> (ø)
trio/__init__.py 100% <100%> (ø) ⬆️
trio/tests/conftest.py 100% <100%> (ø) ⬆️
trio/tests/test_open_tcp_stream.py 100% <100%> (ø)
trio/_open_tcp_stream.py 96.66% <96.66%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e237b6e...8083a79. Read the comment docs.

@njsmith njsmith changed the title [WIP] First draft of some happy eyeballs code Implement happy eyeballs Jul 30, 2017
@njsmith
Copy link
Member Author

njsmith commented Jul 30, 2017

This is now working, and has comprehensive tests!

The docs are a mess; I just shoved the new functions in somewhere that isn't too terrible, but really that whole section needs to be reorganized soon. Maybe better to wait until we have the server stream APIs working though? I dunno.

@njsmith njsmith merged commit fef2215 into python-trio:master Aug 3, 2017
@njsmith njsmith deleted the happy-eyeballs branch August 3, 2017 08:01
@njsmith njsmith mentioned this pull request Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants