Move set_wakeup_fd into common code, used on all platforms #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switched signal_raise to always run the C-level signal handler in the current thread, which gives us more control over signal delivery and lets us test the new behavior. Fixes python-triogh-109
Codecov Report
@@ Coverage Diff @@
## master #1267 +/- ##
==========================================
+ Coverage 99.57% 99.57% +<.01%
==========================================
Files 106 106
Lines 12836 12852 +16
Branches 985 987 +2
==========================================
+ Hits 12781 12797 +16
Misses 35 35
Partials 20 20
|
Tronic
reviewed
Oct 25, 2019
Comment on lines
+1786
to
+1790
| with runner.entry_queue.wakeup.wakeup_on_signals(): | ||
| # The main reason this is split off into its own | ||
| # function is just to get rid of this extra | ||
| # indentation. | ||
| run_impl(runner, async_fn, args) |
There was a problem hiding this comment.
Wrapping a comment about indentation width to a third line because of the column limit? I wish the world already switched to 120 characters instead of the width of 1980's graphics adapters and terminals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switched signal_raise to always run the C-level signal handler in
the current thread, which gives us more control over signal delivery
and lets us test the new behavior.
Fixes gh-109