add libcst as install_requires, print errors to stderr & return 1/0, add pre-commit hook & update config, #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
force-pushed
the
pre_commit_support
branch
from
72d937c to
6213187
Compare
|
rejigged the tests a bit to have two tests explicitly for SystemExit. |
jakkdl
force-pushed
the
pre_commit_support
branch
from
6213187 to
1560ee2
Compare
Zac-HD
approved these changes
Mar 22, 2023
Automated via this ci config invoking this janky code! It's not pretty, but it works 😅 |
|
haha that's some beautiful jank! I'll add it in a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't come up with any good ways of writing an automated test for pre-commit, but tested it locally and against my fork - and therefore finding the catastrophically bad errors in init & setup 😅
I was a bit surprised missing libcst wasn't picked up by tox, but that's because the testenv depends on hypothesmith - which requires libcst.
We surely want to start tagging releases though, I looked at shed's CI workflow if there were anything there that automatically created tags but didn't find anything so I'm a bit curious if/how you automate that or if you manually do it on releasing.