-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unrestricted API for user info #363
base: master
Are you sure you want to change the base?
Conversation
Given python-social-auth#335, I propose to change the URL. The default one is restricted in the number of queries per day.
The tests are failing, but I can't understand why... |
As the end point is not the same, the expected value was incorrect.
This pull request solves one issue (connection using iOS SDK with returns id_token, not access_token), but breaks the login via the /complete/google-oauth endpoint, because this uses the access_token, not the same as id_token. |
Solution: try both... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
hello, |
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 76.18% 76.16% -0.02%
==========================================
Files 314 314
Lines 9497 9499 +2
Branches 465 465
==========================================
Hits 7235 7235
- Misses 2110 2112 +2
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Given #335, I propose to change the URL. The default one is restricted in the number of queries per day.