Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace poetry shell command with poetry env activate #9763

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Oct 12, 2024

Pull Request Check List

Resolves: personal grudge towards poetry shell

  • Added tests for changed code.
  • Updated documentation for changed code.

@Secrus Secrus added the impact/docs Contains or requires documentation changes label Oct 14, 2024
@Secrus Secrus marked this pull request as ready for review October 14, 2024 20:02
@Secrus Secrus requested a review from a team October 14, 2024 20:02
Copy link

github-actions bot commented Oct 14, 2024

Deploy preview for website ready!

✅ Preview
https://website-eenyz1u4w-python-poetry.vercel.app

Built with commit bf8fb71.
This pull request is being automatically deployed with vercel-action

src/poetry/console/commands/env/activate.py Outdated Show resolved Hide resolved
src/poetry/console/commands/env/activate.py Outdated Show resolved Hide resolved
tests/console/commands/env/test_activate.py Outdated Show resolved Hide resolved
src/poetry/console/commands/env/activate.py Outdated Show resolved Hide resolved
src/poetry/console/commands/env/activate.py Outdated Show resolved Hide resolved
docs/cli.md Show resolved Hide resolved
docs/managing-environments.md Outdated Show resolved Hide resolved
docs/managing-environments.md Show resolved Hide resolved
docs/managing-environments.md Show resolved Hide resolved
@Secrus Secrus force-pushed the remove-shell branch 3 times, most recently from 88e64b0 to 6c7a9e8 Compare October 27, 2024 17:26
@Secrus Secrus requested a review from radoering October 27, 2024 20:38
@Secrus Secrus enabled auto-merge (squash) October 28, 2024 16:27
@Secrus Secrus merged commit 6d6971e into python-poetry:main Oct 28, 2024
74 checks passed
@Secrus Secrus deleted the remove-shell branch October 28, 2024 18:45
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants