Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trust empty requires dist with modern metadata #9078

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

dimbleby
Copy link
Contributor

when modern metadata says that it has no requires-dist, we can trust it

I bet it doesn't often matter:

  • Metadata 2.2 and 2.3 pypi/warehouse#13606 was only just released
  • as of today presumably more or less no-one (poetry included) is yet publishing metadata versioned at 2.2 or higher
  • and probably nearly all newly published packages also publish wheels anyway.

still, when it happens it happens, and avoiding unnecessary builds is a good win

@dimbleby dimbleby force-pushed the pep-643 branch 2 times, most recently from 65f0728 to 878d091 Compare February 29, 2024 22:02
@dimbleby
Copy link
Contributor Author

dimbleby commented Mar 4, 2024

prior to their 1.10, the pkginfo parsing of files with metadata 2.3 failed to return any useful values.

this is more or less a proof that no-one was declaring metadata version 2.3: because if they did then things would surely go wrong.

However I see that maturin has just merged a change such that their backend will start declaring metadata version 2.3, and it looks as though they are about to cut a 1.5.0 release, and so fairly soon there will likely be a fresh supply of metadata-2.3 packages. Once that happens I would not be surprised to see a little flurry of issues for which the answer will be "upgrade pkginfo in your poetry installation".

I've bumped the pkginfo requirement in this MR to 1.10, and made one of the test fixtures use metadata version 2.3.

@dimbleby dimbleby force-pushed the pep-643 branch 2 times, most recently from b19553d to 89922a1 Compare March 4, 2024 20:21
@dimbleby
Copy link
Contributor Author

dimbleby commented Mar 8, 2024

I see that #9130 rediscovered some of the above

@abn abn merged commit 9b3893a into python-poetry:main Mar 22, 2024
22 checks passed
@dimbleby dimbleby deleted the pep-643 branch March 23, 2024 10:14
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants