Support for bundling and installing to a target directory #799
Conversation
|
@sdispater Could you help me with the appveyor build error, and also point me in the right direction re the test cases? |
|
Will this be resolved soon? looking for the --target option and the only conflict here is the docs. |
|
+1 to this change. |
|
@rajeev Thanks for contributing! I'll leave @sdispater to decide on whether this gets merged. Would you be able to rebase off of latest @dsully use the thumbs up on the issue if you want to vote for something. We can then sort by that. We can't sort by comments with thumbs up. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Was a decision made about supporting If there is no opposition to add the feature to poetry, (I propose this as I'm really interested by the feature, and there was no news from @rajeev) |
|
I hope to see this merged soon. We need it for bundling Dependencies for AWS Lambda deploys. |
| @@ -13,6 +13,7 @@ class InstallCommand(EnvCommand): | |||
| (implicitly enables --verbose). } | |||
| { --E|extras=* : Extra sets of dependencies to install. } | |||
| { --develop=* : Install given packages in development mode. } | |||
| { --target= : Install all dependencies into target directory. } | |||
There was a problem hiding this comment.
why don't we add a shortcut for this option -t
| if self.target: | ||
| cmd.extend(["--target", self.target]) | ||
| else: | ||
| cmd.extend(["-e"]) |
There was a problem hiding this comment.
it would be nice to use a full option in the code for the sake of readability
|
+1 to wanting to see this merged |
|
@finswimmer I disagree. The pr you linked to is to make a venv. This is to set the target install directory. They have different use cases. |
|
could we re-visit this change please? |
|
Any update on this? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The purpose of this PR is to add a new cli option to the install command (--target). It bundles all the dependencies and installs them into a given target directory. This would make it simpler to setup deployment packages for AWS Lambda as well as other similar use cases.
Notes:
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the
developbranch. If it's a bug fix or only a documentation update, it should be based on themasterbranch.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!