refactor: extract cache utilities #7621
Merged
+419
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ralbertazzi
force-pushed
the
feat/cache-url-dependencies
branch
4 times, most recently
from
43171ac to
3c08430
Compare
|
I went ahead at moving |
radoering
requested changes
Mar 11, 2023
radoering
force-pushed
the
feat/cache-url-dependencies
branch
from
44c0f95 to
abff1a2
Compare
radoering
approved these changes
Mar 19, 2023
1 task
adriangb
pushed a commit
to adriangb/poetry
that referenced
this pull request
Apr 5, 2023
Co-authored-by: Randy Döring <[email protected]>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
As discuss with @radoering in #7595, this is a first refactor PR that tries to extract cache utilities outside of Chef. The end goal is to resolve finally #2415.
artifacts_cache_directoryproperty to config.py analoguous torepository_cache_directoryget_cached_archives_for_link()independent from interpreter_name and interpreter_versionget_cached_archives_for_linkandget_cache_directory_for_linkfromchef.pytoutils/cache.pyI ended up moving the recently touched
get_cached_archive_for_linktoo, although it looks to me that it's not such a generic utility, but it's mostly related to the installation step. The fact that I had to refactor a bit theinstallerpackage to avoid circular imports makes this evident. Still, I believedchef.pywasn't the best place to keep that function since the other ones have been moved. I'm happy to receive feedback on this and other possible solutions. Most likely I would putget_cached_archive_for_linkdirectly insideExecutor( which is the only user of that function), but I wanted to get your feedback first.[ ] Updated documentation for changed code.