-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export command #675
Export command #675
Conversation
Bonjour Sébastien, I'm glad you've worked on this feature. In my spare time I was working also on this feature. It was almost finished, I just needed to add more tests before sending you a pull request. But now it's too late! I've compared your code with mine and many things are the same but their's also some differences. You can check my code here. Here are the major differences I can see:
That's mostly that. The features that are in my code and not in yours that I wish the most you will add are the points 4, 8 and 9. I also worked on a feature I was definitely not sure it was a good idea: autoupdating of requirements.txt and requirements-dev.txt files when the lock file is modified. You can check this code here. One of my problem with this is that the code need to deduce some settings ( Feel free to do whatever you want with my code and ideas (ignore them, borrow from them, etc.) and thanks for your work! |
While I fancy the feature per se, I don’t like the hard coded output file name. What about doing it in the traditional Unix command style, i.e., printing to stdout by default, thus giving the user the possibility to redirect the output to a file, or pipe it into another command for further processing? |
Following up on this one, I have started to work on a PR; see #1035. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
This PR introduces a new
export
command that can export the lock file to alternative formats. Currently only therequirements.txt
format is supported.This will help the transition especially for systems and tools that only understand a
requirements.txt
file.