Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix failing tests due to updated list of available pythons #6561

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Sep 19, 2022

Fixes tests, that will fail when changes in python-poetry/poetry-core#477 are merged.

(Checks in the first commit shows that should work)

@finswimmer finswimmer force-pushed the fix/downstream-test-available-pythons branch from c999d66 to 72fa562 Compare September 19, 2022 11:30
@finswimmer finswimmer marked this pull request as ready for review September 19, 2022 12:31
@finswimmer finswimmer requested a review from a team September 19, 2022 12:32
mkniewallner
mkniewallner previously approved these changes Sep 24, 2022
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like it would make more sense to interrogate core for the Python versions and check that they are all reflected in the markers. Are we opposed to doing that, instead of hardcoding the output?

@radoering
Copy link
Member

I took a quick look and it seems "interrogating core for the versions" works only for the test in test_editable_builder.py. In test_factory.py it's not all versions from AVAILABLE_PYTHONS, but only the versions which are supported by the project. So it's actually reimplementing all_classifiers (or comparing it to itself). Thus, maybe just keep it hardcoded in both places.

@radoering radoering force-pushed the fix/downstream-test-available-pythons branch from 72fa562 to 2adfbe6 Compare October 4, 2022 16:46
@radoering radoering added area/testing Related to the test suite impact/backport Requires backport to stable branch backport/1.2 labels Oct 4, 2022
@finswimmer
Copy link
Member Author

I came to the same conclusion as @radoering, but forget to answer.

@radoering radoering enabled auto-merge (squash) October 4, 2022 17:24
@radoering radoering merged commit f8ecaca into python-poetry:master Oct 4, 2022
@poetry-bot
Copy link

poetry-bot bot commented Oct 4, 2022

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6561-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f8ecaca63bd17d5308fbaa2394575d3933d98349
# Push it to GitHub
git push --set-upstream origin backport-6561-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport-6561-to-1.2.

radoering added a commit to radoering/poetry that referenced this pull request Oct 4, 2022
neersighted pushed a commit that referenced this pull request Oct 4, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/testing Related to the test suite impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants