-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix failing tests due to updated list of available pythons #6561
fix: fix failing tests due to updated list of available pythons #6561
Conversation
c999d66
to
72fa562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like it would make more sense to interrogate core for the Python versions and check that they are all reflected in the markers. Are we opposed to doing that, instead of hardcoding the output?
I took a quick look and it seems "interrogating core for the versions" works only for the test in |
72fa562
to
2adfbe6
Compare
I came to the same conclusion as @radoering, but forget to answer. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6561-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f8ecaca63bd17d5308fbaa2394575d3933d98349
# Push it to GitHub
git push --set-upstream origin backport-6561-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2 Then, create a pull request where the |
…on-poetry#6561) (cherry picked from commit f8ecaca) Co-authored-by: Randy Döring <[email protected]>
(cherry picked from commit f8ecaca) Co-authored-by: Randy Döring <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes tests, that will fail when changes in python-poetry/poetry-core#477 are merged.
(Checks in the first commit shows that should work)