ensure provider respects subdirectory when merging and imrove subdirectory support for vcs deps #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
force-pushed
the
improve-coverage-merge
branch
from
0758c4a to
41d214b
Compare
abn
commented
May 19, 2022
abn
commented
May 19, 2022
Secrus
requested changes
May 19, 2022
This change is required to allow for subdirectories.
abn
force-pushed
the
improve-coverage-merge
branch
from
41d214b to
0c52d7a
Compare
Secrus
previously approved these changes
May 19, 2022
…olving fails to avoid weird messages like "Because myapp depends on both demo (1.2.3) and demo (1.2.3), version solving failed."
|
@abn I took the liberty of adding a small improvement to avoid weird error messages like "Because myapp depends on both demo (1.2.3) and demo (1.2.3), version solving failed." Otherwise looks fine. 👍 Can be merged if CI passes and the change is OK for you. |
radoering
approved these changes
May 21, 2022
2 tasks
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.