Alter rev-parse syntax to support msys git #2668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, msys and cygwin versions of git need braces to be escaped when they
are invoked via subprocess. (This appears to be is a side effect of the machinery
that converts windows paths to posix-like paths for the executable).
If they are not escaped, then "rev^{commit]" becomes a meaningless "rev^commit"
to an msys git, resulting in an error.
In contrast, we do not want to escape the braces if passing "rev^{commit}" to any
other form of git. We can avoid having to decide whether escaping is needed by
using the alternative notation "^0".
3 tasks
finswimmer
approved these changes
Aug 16, 2020
finswimmer
requested changes
Aug 16, 2020
2 tasks
|
@finswimmer Rebasing is no help here, all the relevant code has moved to the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows,
msysandcygwinversions ofgitneed braces to be escaped when they are invoked via subprocess. (This appears to be an unfortunate side effect of the machinery that converts windows paths to posix-like paths for the executable, and is usually hidden when executing from an msys based shell).If they are not escaped, then
rev^{commit]becomes a meaninglessrev^committo anmsysgit, resulting in an error.In contrast, we do not want to escape the braces if passing
rev^{commit}to any other form ofgit. We can avoid having to decide whether escaping is needed by using the alternative notation^0.As noted in the
rev-parsedocumentationPull Request Check List
Resolves: #2667