Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LICENSES folder and other edge cases with license file inclusion #2573

Closed
wants to merge 2 commits into from

Conversation

MrJohz
Copy link

@MrJohz MrJohz commented Jun 17, 2020

Pull Request Check List

Resolves: #2565

  • Added tests for changed code.
  • Updated documentation for changed code.

(I'm not sure if there was any documentation on this topic to start with, so I haven't added any. However, it would probably be good to see some documentation here in the first place, so I can also add that if you want.)

MrJohz added 2 commits June 17, 2020 09:17
* No longer crashes if a potential license file is a directory
* Recursively searches inside the "LICENSES" folder for additional
licenses (matches the REUSE specification)
@MrJohz
Copy link
Author

MrJohz commented Aug 10, 2020

I'm closing this PR in favour of python-poetry/poetry-core#57, given that the underlying code has been moved to the core repository.

@MrJohz MrJohz closed this Aug 10, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip local install (via PEP 517) fails if a folder named LICENSES is present in the source code
1 participant