Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about tox to FAQ section #227

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

tadeoos
Copy link
Contributor

@tadeoos tadeoos commented Jun 17, 2018

This PR adds info about using tox with Poetry as discussed in #222.

There is no contributing guide so I am not sure if this should be merged to master or develop branch, but since other PRs are merging into master, I followed their lead.

@tadeoos
Copy link
Contributor Author

tadeoos commented Jun 17, 2018

@sdispater I want to make sure that the info in FAQ is actually enough: I wonder if tox will be able to execute the poetry commands in venvs since it is not being installed anywhere explicitly...

@sdispater
Copy link
Member

As long as you have poetry installed on your system, you should be fine. That's why we have to specify whitelist_externals = poetry to tell tox to execute the poetry executable located outside the tox virtualenv.

@tadeoos
Copy link
Contributor Author

tadeoos commented Jun 17, 2018

Great, thanks!

@sdispater sdispater merged commit 6a7a872 into python-poetry:master Jun 18, 2018
@sdispater
Copy link
Member

Looks good to me. Thanks!

@sobolevn sobolevn mentioned this pull request Jun 19, 2018
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants