-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): sort global opts prior to io config #10128
Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue where global options were not being correctly applied due to incorrect ordering of operations. The fix involves reordering the call to sort global options to ensure they are applied before IO configuration. Sequence diagram for updated global options configuration flowsequenceDiagram
participant App as Application
participant IO as IO Configuration
participant Options as Global Options
Note over App,Options: Before Change
App->>Options: _sort_global_options()
App->>IO: Configure IO
App->>Options: Configure global options
Note over App,Options: After Change
App->>IO: _configure_run_command()
App->>Options: _sort_global_options()
App->>IO: Configure IO
App->>Options: Configure global options
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Testing this change
Using pipx
Using a container (podman | docker)
Summary by Sourcery
Bug Fixes: