Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for named Other/Proprietary Licenses #2020

Closed
2 tasks done
cfarrend opened this issue Feb 11, 2020 · 1 comment · Fixed by python-poetry/poetry-core#5
Closed
2 tasks done

Add support for named Other/Proprietary Licenses #2020

cfarrend opened this issue Feb 11, 2020 · 1 comment · Fixed by python-poetry/poetry-core#5
Labels
kind/feature Feature requests/implementations

Comments

@cfarrend
Copy link

cfarrend commented Feb 11, 2020 •
edited
Loading

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Currently

When you want to use the Other/Proprietary License license type you specify in your pyproject.toml file:

license = "Proprietary"

When uploaded to PyPi, the license shows as the following in the metadata section:

License: Other/Proprietary License (Proprietary)

Desired

We wish to specify our own License name for the Other/Proprietary License instead of the generic "Proprietary" such that we can put in links to our own licenses, or provide the name of the license if not natively supported by PyPi. Some examples are here:

Code

Having a dig around the code seems to be around here

poetry/poetry/spdx/__init__.py

Line 48 in ed44342

_licenses["proprietary"] = License("Proprietary", "Proprietary", False, False)

https://github.com/python-poetry/poetry/blob/master/poetry/spdx/license.py
@cfarrend cfarrend added the kind/feature Feature requests/implementations label Feb 11, 2020
abn added a commit to abn/poetry that referenced this issue Mar 19, 2020
@abn
Relax licence restrictions to support custom licences
fb2a2aa 
This change adds support of use of custom licenses for projects. If the
value specified for `licence` is not in the SPDX License List or
"Proprietary", we treat it as a custom licence withe value (as is) as
the name.

As a side-effect, the validation of licence is no longer performed when
executing `poetry check`.

Resolves: python-poetry#2020
@abn abn mentioned this issue Mar 19, 2020
Closed
2 tasks
abn added a commit to abn/poetry-core that referenced this issue Mar 27, 2020
@abn
Relax licence restrictions to support custom licences
32d4115 
This change adds support of use of custom licenses for projects. If the
value specified for `licence` is not in the SPDX License List or
"Proprietary", we treat it as a custom licence withe value (as is) as
the name.

As a side-effect, the validation of licence is no longer performed when
executing `poetry check`.

Resolves: python-poetry/poetry#2020
@abn abn mentioned this issue Mar 27, 2020
Merged
abn added a commit to python-poetry/poetry-core that referenced this issue Apr 1, 2020
@abn
Relax licence restrictions to support custom licences
d62352f 
This change adds support of use of custom licenses for projects. If the
value specified for `licence` is not in the SPDX License List or
"Proprietary", we treat it as a custom licence withe value (as is) as
the name.

As a side-effect, the validation of licence is no longer performed when
executing `poetry check`.

Resolves: python-poetry/poetry#2020
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Feature requests/implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax licence restrictions to support custom licences abn/poetry-core
1 participant
@cfarrend