-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support git subfolder #9
support git subfolder #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked to previous relevant discussion.
@@ -14,7 +14,8 @@ | |||
"port": r"\d+", | |||
"path": r"[\w~.\-/\\]+", | |||
"name": r"[\w~.\-]+", | |||
"rev": r"[^@#]+", | |||
"rev": r"[^@#?]+", | |||
"subdir": r"[\w\-/\\]+", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to previous discussion concerning this bit. python-poetry/poetry#1822 (comment)
Is there any indication when this will make it into a (pre)release? I've got a |
Hello @dancmeyers, unfortunately I think this feature has to wait for poetry version 1.2. fin swimmer |
Supporting git subfolders is the missing piece of the puzzle for several repos I work on. I'd love to see this PR merged, @finswimmer is there anything I could do to help? - or is the poetry 1.2 requirement dependent on upstream tasks? |
I'm closing this PR and the related in python-poetry/poetry#2242 for the following reasons:
|
This PR contains necessary changes to poetry_core for implementing the possibility to add subfolders of a git repository as dependency.
This was original implemented in python-poetry/poetry#1822.
Merging this PR requires merging of python-poetry/poetry#2242 in poetry as well.
Implements: python-poetry/poetry#755