Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support git subfolder #9

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Mar 29, 2020

This PR contains necessary changes to poetry_core for implementing the possibility to add subfolders of a git repository as dependency.

This was original implemented in python-poetry/poetry#1822.

Merging this PR requires merging of python-poetry/poetry#2242 in poetry as well.

Implements: python-poetry/poetry#755

Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to previous relevant discussion.

@@ -14,7 +14,8 @@
"port": r"\d+",
"path": r"[\w~.\-/\\]+",
"name": r"[\w~.\-]+",
"rev": r"[^@#]+",
"rev": r"[^@#?]+",
"subdir": r"[\w\-/\\]+",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to previous discussion concerning this bit. python-poetry/poetry#1822 (comment)

@abn abn added the Feature label Apr 1, 2020
@dancmeyers
Copy link

Is there any indication when this will make it into a (pre)release? I've got a pipenv project that takes over 15 minutes to lock dependencies that it's pulling from GitHub, and some basic testing suggests poetry should be a lot faster, but until I can install from subfolders we're out of luck...

@finswimmer
Copy link
Member Author

Hello @dancmeyers,

unfortunately I think this feature has to wait for poetry version 1.2.

fin swimmer

@danodonovan
Copy link

Supporting git subfolders is the missing piece of the puzzle for several repos I work on. I'd love to see this PR merged, @finswimmer is there anything I could do to help? - or is the poetry 1.2 requirement dependent on upstream tasks?

@finswimmer
Copy link
Member Author

I'm closing this PR and the related in python-poetry/poetry#2242 for the following reasons:

  • poetry's code base has changed a lot. I guess it would be easier to start from scratch then trying to adopt the current implementation
  • I'm not aware of any PEP that says how to describe a git dependency located in a subfolder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants