constraints: allow whitespace padding in caret constraints (for consistency) and consolidate parse_constraint tests
#606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stency) and consolidate `parse_constraint` tests
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests regarding whitespace padding were spread over several tests, although there already has been a dedicated test:
test_parse_constraint_with_white_space_padding. However, this test did not only test whitespace padding but additional stuff that is already tested in the other tests (or at least fits better there).This PR, removes duplicated tests and moves tests from
test_parse_constraint_with_white_space_paddingto other tests and vice versa to sharpen the objective of each test. Further, it improvestest_parse_constraint_with_white_space_paddingby systematically applying whitespace padding not only at the beginning and at the end of a constraint, but everywhere it is possible.Thereby, it was noticed that padding was allowed for all types of constraints but caret constraints. This PR fixes this inconsistency.