Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump poetry.core.__version__ with test coverage #367

Merged
merged 2 commits into from
May 24, 2022
Merged

bump poetry.core.__version__ with test coverage #367

merged 2 commits into from
May 24, 2022

Conversation

abn
Copy link
Member

@abn abn commented May 24, 2022 •
edited
Loading

As discussed with @neersighted on discord, going with the simple bump as importlib.metadata.version is a bit more tricky to do here. And if we want to drop __version__ we need to drop it's use in wheel builder and/or accept that version will not be available for in-tree builds unless we parse pyproject.toml file.

Closes: #366

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abn abn requested a review from neersighted May 24, 2022 02:10
finswimmer
finswimmer approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abn abn merged commit 96c43de into python-poetry:main May 24, 2022
@abn abn mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finswimmer finswimmer finswimmer approved these changes

@neersighted neersighted Awaiting requested review from neersighted

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abn @finswimmer @dimbleby