typechecking semver.version_union #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2022
abn
reviewed
May 12, 2022
dimbleby
force-pushed
the
typing/version-union
branch
3 times, most recently
from
95f1961 to
58faf49
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@abn are we waiting on anything to get this merged? |
neersighted
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that if we can get the MRs merged, this will complete the typechecking campaign in poetry-core 🎉 .
Specifically:
(though it does look as though #339 may have some non-trivial conflicts at the moment).
It would be a stretch to call this a blocker for the next release; but it would be awfully nice to get this mini-project completed.