Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PEP 660 hooks #182

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Support PEP 660 hooks #182

merged 1 commit into from
Aug 18, 2021

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Jun 29, 2021 •
edited
Loading

Implements hooks according to PEP 660

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer force-pushed the pep-660 branch 3 times, most recently from 419a8c5 to 4d9a273 Compare June 29, 2021 17:51
@finswimmer finswimmer force-pushed the pep-660 branch 3 times, most recently from 00ba74e to 2db5094 Compare July 3, 2021 09:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@finswimmer finswimmer marked this pull request as ready for review August 2, 2021 04:48
@finswimmer finswimmer requested review from a team and sdispater August 2, 2021 04:48
@finswimmer finswimmer mentioned this pull request Aug 2, 2021
Closed
@coroa coroa mentioned this pull request Aug 10, 2021
Closed
sdispater
sdispater approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sdispater sdispater merged commit 5812d6d into python-poetry:master Aug 18, 2021
airstandley added a commit to airstandley/poetry-core that referenced this pull request Aug 18, 2021
@airstandley
build_editable added in python-poetry#182 referenced non-existent 'wi…
1811899 
…th_dev' parameter in the Factory.create_poetry call. Removed this parameter from the call.
@pradyunsg pradyunsg mentioned this pull request Nov 14, 2021
Open
1 task
@amleczko
Copy link

amleczko commented Dec 8, 2021

Any plans for releasing this PR? Any ETA?

@jaklan
Copy link

jaklan commented Dec 16, 2021

People in both poetry and poetry-core repos are waiting for this release very badly, @finswimmer / @sdispater - please just provide any information about the expected release date...

@jhrmnn
Copy link

jhrmnn commented Jan 4, 2022 •
edited
Loading

Before the feature is released, one can still use it with:

[build-system]
requires = ["poetry-core@https://github.com/python-poetry/poetry-core/archive/325312c016d69189ac93c945ba0c1b69296c5e54.zip"]

325312c is a fix of the PEP 660 hook.

@iamamutt iamamutt mentioned this pull request Jan 14, 2022
Closed
@finswimmer finswimmer mentioned this pull request Feb 9, 2022
Merged
@DMRobertson DMRobertson mentioned this pull request Feb 23, 2022
Closed
@MeltyBot MeltyBot mentioned this pull request May 29, 2022
Closed
@JackUrb JackUrb mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdispater sdispater sdispater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@finswimmer @amleczko @jaklan @jhrmnn @sdispater