Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output valid file URLs when building requirements #141

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Output valid file URLs when building requirements #141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81317b4
Output valid file URLs when building requirements
Mar 21, 2021
1d3e00e
Address @abn's feedback
Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion poetry/core/packages/directory_dependency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from .constraints import BaseConstraint # noqa

from .dependency import Dependency
from .utils.utils import path_to_url


class DirectoryDependency(Dependency):
Expand Down Expand Up @@ -121,7 +122,8 @@ def base_pep_508_name(self) -> str:
if self.extras:
requirement += "[{}]".format(",".join(self.extras))

requirement += " @ {}".format(self._path.as_posix())
path = path_to_url(self.path) if self.path.is_absolute() else self.path
requirement += " @ {}".format(path)

return requirement

Expand Down