Relax licence restrictions to support custom licences #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy over old test cases from poetry repository.
This change adds support of use of custom licenses for projects. If the value specified for `licence` is not in the SPDX License List or "Proprietary", we treat it as a custom licence withe value (as is) as the name. As a side-effect, the validation of licence is no longer performed when executing `poetry check`. Resolves: python-poetry/poetry#2020
2 tasks
kasteph
approved these changes
Mar 29, 2020
There was a problem hiding this comment.
The PR is sound and I would like to see this merged. @sdispater are there any concerns on your end about this feature?
|
This was okayed on discored. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support of use of custom licenses for projects. If the
value specified for
licenceis not in the SPDX License List or"Proprietary", we treat it as a custom licence withe value (as is) as
the name.
As a side-effect, the validation of licence is no longer performed when
executing
poetry check.Resolves: python-poetry/poetry#2020