Remove TokenParser #453
Merged
Remove TokenParser #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
force-pushed
the
remove-token-parser
branch
from
2b854df
to
c1ef304
Compare
Secrus
force-pushed
the
remove-token-parser
branch
from
c1ef304
to
a2a374a
Compare
trag1c
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TokenParserworks the same asshlex.splitfunction from the standard library, so there is no need to keep it.This PR consists of 2 commits, the first contains a test, verifying that the output of
TokenParser.parseis the same asshlex.split. The second features actual removal. When merging, the commits should be squashed.