-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename custom exceptions form *Exception to *Error #179
Conversation
nb this is a breaking change. If you're going to make breaking changes, it's worth considering more cleanup than this.
I realise that you were likely just looking to do a small tidy-up and not get into all this. But breaking changes should be rare: and if you're going to make breaking changes anyway, then that's the opportunity to make such improvements. |
Thanks for your input, I appreciate it. I will look into what you pointed out. I am aware that those are breaking changes, but as far as I know, the next release is gonna be 1.0.0 which could be a good point to introduce such changes, especially since we are working towards better code quality with more flake8 checks and the introduction of type checking via mypy. |
7bac59a
to
0109854
Compare
0109854
to
5154d66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; but I would like to see the doc strings introduced have consistent punctuation.
I'd also squash the two commits -- the entire codebase is broken after the first one, so I do not see any value in splitting them.
5154d66
to
6480f3b
Compare
Resolves: #162