Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inspect.stack() with traceback.extract_stack() to solve performance bottleneck #716

Merged
merged 1 commit into from
Aug 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pendulum/datetime.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import calendar
import datetime
import sys
import traceback

from typing import TYPE_CHECKING
from typing import Any
Expand Down Expand Up @@ -1221,9 +1222,7 @@ def __add__(self, other: datetime.timedelta) -> Self:
# This is a workaround for Python 3.8+
# since calling astimezone() will call this method
# instead of the base datetime class one.
import inspect

caller = inspect.stack()[1][3]
caller = traceback.extract_stack(limit=2)[0].name
if caller == "astimezone":
return super().__add__(other)

Expand Down