Adjust for custom charset encoding of form request variables with Python 3 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with Python 3 When sending latin-encoded form fields, "mechanize" bailed out with "TypeError: must assign a string" on Python 3. This accounts for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
thank you all for conceiving and maintaining
mechanize. While using it that long already, we are finally happy to contribute something.When upgrading to Python 3, we encountered the same issue as #32 when the form should be submitted in "iso-8859-1" encoding.
When sending latin-encoded form fields, "mechanize" bailed out with
on Python 3 while everything worked fine on Python 2 here. This PR accounts for that by also accepting readily encoded
byteswhen setting form fields, which then worked flawlessly for us. An appropriate test nails the amended behavior.Thanks a bunch already for looking at this.
With kind regards,
Andreas.