Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve references #1006

Closed
wants to merge 4 commits into from

Conversation

chbrandt
Copy link

@chbrandt chbrandt commented Oct 6, 2022

This is the old PR #419 from @kave merged into current main as suggested in thread/comment in python-jsonschema/referencing#2 .

Pytest is running fine. Tox is complaining about the docs somewhere.
I am pushing the PR anyways to not let it pass (code-wise).


📚 Documentation preview 📚: https://python-jsonschema--1006.org.readthedocs.build/en/1006/

@Julian
Copy link
Member

Julian commented Oct 6, 2022

Thanks! I'm definitely still up for something like this, but it's a bit harder than it was now -- there's $dynamicRef to handle at this point as well.

@chbrandt
Copy link
Author

chbrandt commented Oct 6, 2022

Yes, I see. Well, maybe we could put that (i.e, dynamicRef) as a "known issue/limitation"?

Programmatically, the functionality could be enabled for when Draft07 validator was being use, or (ii) as a function ("util") outside Resolver.

@Julian
Copy link
Member

Julian commented Oct 6, 2022

$dynamicRef is present in currently supported drafts, and this function should be usable externally if someone has an urgent need, so I honestly would probably not merge until/unless it supports all the current drafts.

@chbrandt
Copy link
Author

chbrandt commented Oct 6, 2022

Got it.

@Julian
Copy link
Member

Julian commented Nov 1, 2022

Happy to take another look at this if/when it handles dynamic references. Appreciated!

@Julian Julian closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants