Switch from bytes_to_send to send returning bytes #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid a blockquote concating these intentionally separate and indented lines.
This allows the outgoing_data buffer to be removed and instead left to the user to be concerned/deal with. This makes it very clear when wsproto has bytes to send (when ``send`` is called), and hence further clarifies the API. It also matches h11 expectations.
Kriechi
approved these changes
Jan 14, 2019
|
Thanks |
|
It looks like this doesn't actually document |
|
It doesn't, I've a proposal for HTTP/2 support I'd like to complete (and hopefully merge) then I plan to rewrite the documentation and examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the ideas in #91.
This allows the outgoing_data buffer to be removed and instead left to the user to be concerned/deal with. This makes it very clear when wsproto has bytes to send (when
sendis called), and hence further clarifies the API. It also matches h11 expectations.