-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider making pyro2 pip-installable #75
Comments
I believe that the main reason pyro wasn't uploaded to pypi in the past was due to the f2py/Fortran dependence, however now that is no longer the case this is definitely something we'd like to do |
now that we've change the pyro directory structure, the issue preventing us from uploading to pypi is that a package with the name pyro already exists. So we either need to figure out how to use a different name with pip or change our name |
okay, this is sorted out now, and we are on pypi as pyro-hydro |
This is unrelated to my JOSS review so don't take this as a blocker for paper acceptance.
You may want to consider making pyro a pip-installable package, rather than relying on the directory structure of the git repository to make it runnable. This will make it easier for users to install pyro (people could just do
pip install pyro2
orconda install -c conda-forge pyro2
) and also make it easier for developers who have worked with other python packages to get set up initially. If you did this you could make thepyro.py
script an executable that gets installed to a user's UNIXPATH
out of the box, so there would be no need to always work in thepyro2
directory or refer to thepyro.py
executable using its full path.The text was updated successfully, but these errors were encountered: