Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting PYTHONPATH is unnecessary? #74

Closed
ngoldbaum opened this issue Feb 20, 2019 · 3 comments
Closed

Setting PYTHONPATH is unnecessary? #74

ngoldbaum opened this issue Feb 20, 2019 · 3 comments

Comments

@ngoldbaum
Copy link
Contributor

It looks like at least the simple advection problem suggested in the readme runs fine on my Python3.7 setup without first setting the PYTHONPATH environment variable to point at the pyro2 directory. Is it still necessary to set that for some other purposes?

@harpolea
Copy link
Collaborator

harpolea commented Feb 20, 2019

If pyro is run from within the main pyro directory, then setting the PYTHONPATH environment variable is unnecessary. However, if the pyro module is imported from within a different directory (as it in is in the notebooks in multigrid/ and examples/), then I believe it will not work unless the pyro directory has been added to the python path.

This would no longer be the case if we made pyro pip-installable, as you suggest in #75

@ngoldbaum
Copy link
Contributor Author

Ah I see. Maybe you want to add a note to the readme and install instructions that setting PYTHONPATH is only necessary if you want to use pyro as a module, not if you only use the pyro.py script.

@harpolea
Copy link
Collaborator

Good idea - I've fixed this in 08c7b61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants